Polish approval mode handling#308
Merged
Merged
Conversation
edwin-zvs
force-pushed
the
zarvis-approval-mode-polish
branch
from
June 1, 2026 02:02
1d65a36 to
4668ef8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auto_reviewask-user fallback open the normal approval prompt instead of ending the tool attemptaauto-review andfunsafe-auto key/decision handlingValidation
cargo test -p agentd-adapter-zarvis auto_review -- --nocapturecargo test -p agentd-adapter-zarvis wait_for_approval_maps -- --nocapturecargo check -p agentd -p agentd-adapter-zarvisgit diff --checkcargo build