Add AGENTD_ZARVIS_REASONING_EFFORT knob for codex-oauth#310
Merged
Conversation
The codex-oauth provider sent `reasoning: { summary: "auto" }` with no
effort field, so requests ran at the backend's default reasoning effort.
Add an optional `AGENTD_ZARVIS_REASONING_EFFORT` env var (low|medium|high)
that sets `reasoning.effort` on the responses body, mirroring Codex CLI's
`model_reasoning_effort`. Unset preserves the previous default behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional
AGENTD_ZARVIS_REASONING_EFFORTenv var (low|medium|high) that setsreasoning.efforton the codex-oauth responses body, mirroring Codex CLI'smodel_reasoning_effort.Why
The codex-oauth provider previously sent
reasoning: { summary: "auto" }with no effort field, so every request ran at the backend's default reasoning effort with no way to change it. The Codex CLI exposesmodel_reasoning_effort; this gives zarvis the same lever.Motivation was benchmark parity: on a DeepSWE task (
etree-xml-diff-patch, gpt-5.5 via the codex-oauth backend), zarvis at the default effort scored 56/57; withAGENTD_ZARVIS_REASONING_EFFORT=highit scored 57/57 — matching the Codex CLI harness (which defaults tohigh).Compatibility
Unset (the default) preserves the exact previous body (
reasoning: { summary: "auto" }), so existing behavior is unchanged.Test plan
cargo build -p agentd-adapter-zarvis(clean).build_responses_bodyunit tests pass unchanged (env unset → identical body).AGENTD_ZARVIS_REASONING_EFFORT=high; observed deeper reasoning and 57/57 on the task above.🤖 Generated with Claude Code