zarvis: default to claude-opus-4-8 / gpt-5 instead of haiku / gpt-5-mini#333
Merged
Conversation
The API-key-based fallback defaults in resolve_model() picked the cheap tier (claude-haiku-4-5 for Anthropic, gpt-5-mini for OpenAI). Bump them to the flagship models so a stock zarvis session uses Opus / GPT-5 by default. Explicit --model and AGENTD_ZARVIS_MODEL still take precedence, and the Ollama fallback is unchanged. Title-generation (title_mode.rs) intentionally stays on the cheap tier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the zarvis harness's API-key-based default models from the cheap tier to the flagship tier in
resolve_model():*_API_KEYpresentANTHROPIC_API_KEYclaude-haiku-4-5claude-opus-4-8OPENAI_API_KEYgpt-5-minigpt-5llama3.1llama3.1(unchanged)Why
A stock zarvis session (no
--model, noAGENTD_ZARVIS_MODEL) fell back to the cheapest model. Defaulting to Opus / GPT-5 gives the better out-of-the-box experience.Scope / not touched
--model/params.modelandAGENTD_ZARVIS_MODELstill win over these defaults.title_mode.rsintentionally left on the cheap tier (haiku /gpt-5-mini) — it's the one-shot session-title generator where a small model is the right call; it still honorsAGENTD_ZARVIS_MODEL.Where the code lives
This PR only touches
crates/adapter-zarvis→ the relevant binary isagentd-adapter-zarvis. All workspace binaries were built (debug) in the worktree; the rest are unchanged frommain.Test
cargo buildsucceeds in the worktree (only pre-existing warnings).🤖 Generated with Claude Code