Skip to content

Keep zarvis approvals out of minibuffer#370

Merged
edwin-zvs merged 1 commit into
mainfrom
no-zarvis-approval-minibuffer
Jun 6, 2026
Merged

Keep zarvis approvals out of minibuffer#370
edwin-zvs merged 1 commit into
mainfrom
no-zarvis-approval-minibuffer

Conversation

@edwin-zvs

Copy link
Copy Markdown
Contributor

Summary

  • keep zarvis-originated tool approvals out of the global TUI minibuffer prompt
  • stop forwarding tool approval requests as orchestrator/operator observations
  • update approval-mode docs so inline approval prompts are the canonical interaction surface

Details

Zarvis already renders risky-tool approval inline in the session PTY, where the user can answer with the approval key. The TUI was also opening a global ApproveTool minibuffer prompt for selected zarvis sessions, and the orchestrator observer could surface approval requests as operator observations.

This changes the TUI to skip the global approval minibuffer for sessions that render approvals inline (zarvis and the orchestrator session). It also removes ToolApprovalRequest from the orchestrator observer allow-list so background approvals do not show up in the operator/minibuffer surface.

Tests

  • cargo test -p agentd-cli approval_prompt -- --nocapture
  • cargo test -p agentd-adapter-zarvis observe -- --nocapture
  • git diff --check
  • cargo build

@edwin-zvs
edwin-zvs merged commit 5d19fdd into main Jun 6, 2026
1 check passed
@edwin-zvs
edwin-zvs deleted the no-zarvis-approval-minibuffer branch June 6, 2026 15:17
@edwin-zvs edwin-zvs mentioned this pull request Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant