Skip to content

smith: fix PTY prompting editor-state flow#393

Merged
edwin-zvs merged 1 commit into
mainfrom
fix-smith-pty-prompt
Jun 7, 2026
Merged

smith: fix PTY prompting editor-state flow#393
edwin-zvs merged 1 commit into
mainfrom
fix-smith-pty-prompt

Conversation

@edwin-zvs

Copy link
Copy Markdown
Contributor

Summary

  • Threaded smith prompt mode through all tool-running/input-drive paths in adapter-smith.
  • Fixed compile break by passing emit_editor_state bool into run_one_tool, run_with_supervisor, and relay/input-drive helpers.
  • Kept behavior where:
    • CONSTRUCT_SMITH_PTY_PROMPT=on enables PTY inline prompt (legacy behavior)
    • CONSTRUCT_SMITH_PTY_PROMPT=off|0|false enables bottom-editor EditorState updates.
  • Added tests for env parsing and preserved existing adapter-smith coverage.

Validation

  • cargo test -p construct-adapter-smith

Closes the WIP issue where CONSTRUCT_SMITH_PTY_PROMPT mode caused tool-run input relay breakage and editor-state duplication.

@edwin-zvs
edwin-zvs merged commit e85e3e1 into main Jun 7, 2026
1 check passed
@edwin-zvs
edwin-zvs deleted the fix-smith-pty-prompt branch June 7, 2026 21:27
edwin-zvs added a commit that referenced this pull request Jun 8, 2026
* Revert "smith: fix editor-state handling in PTY tool runs (#393)"

This reverts commit e85e3e1.

* Revert "smith: add PTY prompt flag default-on; gate EditorState; fix duplicate insertion; WIP isearch to follow (#392)"

This reverts commit cee35f3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant