WebUI: prevent replay-from-start when clicking terminal during initial hydrate#406
Merged
Conversation
… prevent replay-from-start on click
- On terminal host click, if the session's xterm handle isn't loaded yet,
stash a pendingTerminalFocusId and return without refit/claim/focus.
- When hydrate completes (handle.loaded = true), if pendingTerminalFocusId matches,
perform the refit({claim: true, immediate: true}) and focus then clear the flag.
- Prevents Codex/PTY sessions from appearing to replay from the beginning when
clicking during initial pty_replay/transcript hydrate.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When clicking the xterm area in Web UI while Codex (or any PTY-backed) session is still hydrating its initial history, the terminal can appear to replay from the beginning. This patch defers focus/claim until hydrate completes:
pendingTerminalFocusIdand return (no refit/claim/focus yet).handle.loaded = true), ifpendingTerminalFocusIdmatches the session, runrefitTerminal({ claim: true, immediate: true })and focus, then clear the flag.Effect: avoids geometry churn mid-hydrate that can lead to replay-from-start visuals on PTY sessions (Codex).
No behavior change for already-loaded terminals; normal click-to-focus and resize-claim remains instant.