feat(tui): move 'y' alias from archive to delete in C-x k prompt#445
Merged
Conversation
Prompt now reads [d/y] delete / [a] archive / [N] cancel. 'y' is a natural confirmation key so it maps to delete; 'a' is the sole archive key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Swaps the
yalias in theC-x ksession-close prompt:dyaPrompt now reads:
yis a natural "yes, do it" confirmation key, so it maps to the more common delete action. Archive stays onaas the explicit opt-in.Test plan
C-x k→ typey→ session is deletedC-x k→ typed→ session is deletedC-x k→ typea→ session is archivedC-x k→ typen/ Enter → cancelledcargo test session_end_promptpasses (3/3)