Skip to content

Dismiss Help before underlying input#770

Merged
edwin-zvs merged 4 commits into
mainfrom
fix-help-dialog-dismissal
Jul 11, 2026
Merged

Dismiss Help before underlying input#770
edwin-zvs merged 4 commits into
mainfrom
fix-help-dialog-dismissal

Conversation

@edwin-zvs

Copy link
Copy Markdown
Contributor

Summary

  • make the Help dialog consume keyboard input before focused Program/minibuffer/session routing
  • dismiss Help on mouse clicks before underlying hit-testing or child PTY forwarding
  • swallow the matching button-up so the dismissing click cannot activate a covered control
  • add regressions for focused Program keys and complete click dismissal

Tests

  • cargo test -p agentd-cli help_modal_ -- --nocapture
  • cargo test -p agentd-cli (840 behavioral tests passed; known timing-sensitive PTY benchmark failed once, then passed in isolation)
  • cargo test -p agentd-cli pty_render::tests::many_small_events_stay_fast_as_history_grows -- --exact --nocapture
  • cargo test -p agentd-e2e
  • cargo build

Visuals

Not recorded: this fixes input routing for the existing Help dialog without changing its appearance.

@edwin-zvs
edwin-zvs merged commit 3f9785d into main Jul 11, 2026
1 check passed
@edwin-zvs
edwin-zvs deleted the fix-help-dialog-dismissal branch July 11, 2026 04:09
@edwin-zvs edwin-zvs mentioned this pull request Jul 11, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant