feat: remove confirmUpload, upload_requests, and files.status — simplify storage#1049
Merged
pyramation merged 2 commits intomainfrom May 3, 2026
Merged
feat: remove confirmUpload, upload_requests, and files.status — simplify storage#1049pyramation merged 2 commits intomainfrom
pyramation merged 2 commits intomainfrom
Conversation
…storage - Remove confirmUpload mutation entirely (file existence = confirmed) - Remove upload_requests table references from all SQL queries and cache - Remove files.status field — no status gate on downloadUrl - Remove ConfirmUploadInput/ConfirmUploadPayload types - Remove uploadRequestsQualifiedName/uploadRequestsTableName from config - Simplify dedup to just SELECT by key+bucket_id (no status filter) - Simplify file INSERT (no status column) - Remove status_field/status_ready_value/status_pending_value from DataImageEmbedding node type (now INSERT-triggered, mime_type only) - Remove upload_requests from BlueprintEntityStorageProvisions type - Regenerate blueprint-types.generated.ts
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Remove confirmUpload and status from graphile-test.test.ts.snap - Remove ConfirmUploadInput/Payload types from schema-snapshot.test.ts.snap - Rewrite upload.integration.test.ts: remove confirmUpload tests, remove status assertions - Update seed SQL: remove upload_requests table, remove status from files, add UNIQUE(bucket_id, key) - Remove upload_requests_table_id/name from storage_module seed - Update README and package.json descriptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to constructive-db #983. Strips storage upload complexity from the GraphQL plugin layer:
confirmUploadmutation — files are ready immediately after presigned URL PUTupload_requestsfrom storage-module-cache — no moreuploadRequestsQualifiedNamequeriesfiles.statusfrom all paths —downloadUrlno longer gates on status,requestUploadUrlpayload dropsstatusdeduplicated: true, no DB tracking fieldsConfirmUploadInput/ConfirmUploadPayloadtypesDataImageEmbedding— removestatus_field/status_ready_value/status_pending_valueparamsReview & Testing Checklist for Human
plugin.tsno longer registersconfirmUploadmutation — onlyrequestUploadUrlandprovisionBucketremaindownload-url-field.tsserves download URLs without any status check — if file row exists and has a key, it worksstorage-module-cache.tsquery no longer joins/selectsupload_requestscolumnstypes.tsRequestUploadUrlPayloadhas nostatusfieldrequestUploadUrl→ PUT to MinIO →downloadUrlworks immediately (no confirm step)deduplicated: truewithuploadUrl: nullNotes
All 49 CI checks pass.
Merge order: constructive-db #983 first → this PR second. The DB schema removes
upload_requeststable andfiles.statuscolumn; this PR removes the GraphQL plugin code that used them.Link to Devin session: https://app.devin.ai/sessions/ffa3ed8652fc412f976accbdc229c88d
Requested by: @pyramation