fix(types): remove = never default from FindManyArgs TOrderBy param#1154
Merged
Conversation
Same fix as FindFirstArgs — codegen always supplies a concrete TOrderBy, so the default never fires. Removing it avoids a confusing API surface where orderBy appears available but silently rejects all values.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same fix as
FindFirstArgs(PR #1026) — remove the= neverdefault fromFindManyArgs<TSelect, TWhere, TOrderBy>.Codegen always supplies a concrete
TOrderBytype, so the default never fires. Removing it avoids a confusing API surface whereorderByappears available but silently rejects all values (sincenever[]accepts nothing).Files: 1 template + 13 generated SDKs + 1 snapshot + 1 test comment update
Review & Testing Checklist for Human
select-types.tsfiles no longer have= neveronFindManyArgsNotes
FindFirstArgs) and PR refactor: remove NodeHttpAdapter in favor of @constructive-io/fetch #1152 (NodeHttpAdapterremoval)Link to Devin session: https://app.devin.ai/sessions/7d04ac62fc67430aba0aaa40e044eb14
Requested by: @pyramation