Skip to content

fix(types): remove = never default from FindManyArgs TOrderBy param #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyramation merged 1 commit into from
May 13, 2026
Merged

fix(types): remove = never default from FindManyArgs TOrderBy param #1154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion graphql/codegen/src/__tests__/codegen/__snapshots__/client-generator.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ export interface PageInfo {
endCursor?: string | null;
}

export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
select?: TSelect;
where?: TWhere;
orderBy?: TOrderBy[];
Expand Down
6 changes: 2 additions & 4 deletions graphql/codegen/src/__tests__/codegen/react-query-hooks.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,10 +337,8 @@ describe('Query Hook Generators', () => {
});

describe('Regression: FindManyArgs TCondition type arg', () => {
// Bug: queries.ts passed 3 type args to FindManyArgs (TSelect, TWhere, TOrderBy),
// but the template defines 4 params: FindManyArgs<TSelect, TWhere, TCondition = never, TOrderBy = never>.
// This caused TOrderBy to land in the TCondition slot, defaulting TOrderBy to `never`
// and breaking all hook orderBy params.
// Regression guard: queries.ts passes 3 type args to FindManyArgs (TSelect, TWhere, TOrderBy).
// A prior bug had 4 params with defaults, causing TOrderBy to land in the wrong slot.

it('does not include Condition type in generated hooks', () => {
const result = generateListQueryHook(simpleUserTable, {
Expand Down
2 changes: 1 addition & 1 deletion graphql/codegen/src/core/codegen/templates/select-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export interface PageInfo {
endCursor?: string | null;
}

export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
select?: TSelect;
where?: TWhere;
orderBy?: TOrderBy[];
Expand Down
2 changes: 1 addition & 1 deletion sdk/constructive-cli/src/admin/orm/select-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface PageInfo {
endCursor?: string | null;
}

export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
select?: TSelect;
where?: TWhere;
orderBy?: TOrderBy[];
Expand Down
2 changes: 1 addition & 1 deletion sdk/constructive-cli/src/auth/orm/select-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface PageInfo {
endCursor?: string | null;
}

export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
select?: TSelect;
where?: TWhere;
orderBy?: TOrderBy[];
Expand Down
2 changes: 1 addition & 1 deletion sdk/constructive-cli/src/objects/orm/select-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface PageInfo {
endCursor?: string | null;
}

export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
select?: TSelect;
where?: TWhere;
orderBy?: TOrderBy[];
Expand Down
2 changes: 1 addition & 1 deletion sdk/constructive-cli/src/public/orm/select-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface PageInfo {
endCursor?: string | null;
}

export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
select?: TSelect;
where?: TWhere;
orderBy?: TOrderBy[];
Expand Down
2 changes: 1 addition & 1 deletion sdk/constructive-react/src/admin/orm/select-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface PageInfo {
endCursor?: string | null;
}

export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
select?: TSelect;
where?: TWhere;
orderBy?: TOrderBy[];
Expand Down
2 changes: 1 addition & 1 deletion sdk/constructive-react/src/auth/orm/select-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface PageInfo {
endCursor?: string | null;
}

export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
select?: TSelect;
where?: TWhere;
orderBy?: TOrderBy[];
Expand Down
2 changes: 1 addition & 1 deletion sdk/constructive-react/src/objects/orm/select-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface PageInfo {
endCursor?: string | null;
}

export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
select?: TSelect;
where?: TWhere;
orderBy?: TOrderBy[];
Expand Down
2 changes: 1 addition & 1 deletion sdk/constructive-react/src/public/orm/select-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface PageInfo {
endCursor?: string | null;
}

export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
select?: TSelect;
where?: TWhere;
orderBy?: TOrderBy[];
Expand Down
2 changes: 1 addition & 1 deletion sdk/constructive-sdk/src/admin/orm/select-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface PageInfo {
endCursor?: string | null;
}

export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
select?: TSelect;
where?: TWhere;
orderBy?: TOrderBy[];
Expand Down
2 changes: 1 addition & 1 deletion sdk/constructive-sdk/src/auth/orm/select-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface PageInfo {
endCursor?: string | null;
}

export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
select?: TSelect;
where?: TWhere;
orderBy?: TOrderBy[];
Expand Down
2 changes: 1 addition & 1 deletion sdk/constructive-sdk/src/objects/orm/select-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface PageInfo {
endCursor?: string | null;
}

export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
select?: TSelect;
where?: TWhere;
orderBy?: TOrderBy[];
Expand Down
2 changes: 1 addition & 1 deletion sdk/constructive-sdk/src/public/orm/select-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface PageInfo {
endCursor?: string | null;
}

export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
select?: TSelect;
where?: TWhere;
orderBy?: TOrderBy[];
Expand Down
2 changes: 1 addition & 1 deletion sdk/migrate-client/src/migrate/orm/select-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface PageInfo {
endCursor?: string | null;
}

export interface FindManyArgs<TSelect, TWhere, TOrderBy = never> {
export interface FindManyArgs<TSelect, TWhere, TOrderBy> {
select?: TSelect;
where?: TWhere;
orderBy?: TOrderBy[];
Expand Down
Loading