Skip to content

fix(express-context): read auth_settings_table_name directly#1378

Merged
pyramation merged 1 commit into
mainfrom
feat/auth-settings-direct-column
Jul 15, 2026
Merged

fix(express-context): read auth_settings_table_name directly#1378
pyramation merged 1 commit into
mainfrom
feat/auth-settings-direct-column

Conversation

@pyramation

Copy link
Copy Markdown
Contributor

Summary

Removes the transitional coalesce shim in the auth-settings loader now that constructive-db has renamed the column everywhere (constructive-db#2194 merged).

The column sessions_module.auth_settings_table was renamed to auth_settings_table_name to avoid a PostGraphile inflection collision with auth_settings_table_id. #1376 added a compatibility read that tolerated both names:

coalesce(to_jsonb(sm) ->> 'auth_settings_table_name',
         to_jsonb(sm) ->> 'auth_settings_table') AS table_name

Since every metaschema now has the renamed column, this reverts to a direct read:

SELECT s.schema_name, sm.auth_settings_table_name AS table_name
FROM metaschema_modules_public.sessions_module sm
JOIN metaschema_public.schema s ON s.id = sm.schema_id
LIMIT 1

Link to Devin session: https://app.devin.ai/sessions/b0cb3356cae14cc28fa469b4f8fd3e1d
Requested by: @pyramation

Now that constructive-db has renamed the column everywhere (constructive-db#2194
merged), drop the transitional coalesce shim and read sm.auth_settings_table_name
directly.
@pyramation pyramation self-assigned this Jul 15, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@pyramation
pyramation merged commit ff6a571 into main Jul 15, 2026
38 checks passed
@pyramation
pyramation deleted the feat/auth-settings-direct-column branch July 15, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant