fix(express-context): read auth_settings_table_name directly#1378
Merged
Conversation
Now that constructive-db has renamed the column everywhere (constructive-db#2194 merged), drop the transitional coalesce shim and read sm.auth_settings_table_name directly.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the transitional
coalesceshim in the auth-settings loader now that constructive-db has renamed the column everywhere (constructive-db#2194 merged).The column
sessions_module.auth_settings_tablewas renamed toauth_settings_table_nameto avoid a PostGraphile inflection collision withauth_settings_table_id. #1376 added a compatibility read that tolerated both names:Since every metaschema now has the renamed column, this reverts to a direct read:
Link to Devin session: https://app.devin.ai/sessions/b0cb3356cae14cc28fa469b4f8fd3e1d
Requested by: @pyramation