feat(fixtures): adopt the published logical-name plane packages - #1468
Merged
Conversation
…outing schema overrides
- pgpm.json: @constructive-db/{apps,catalog,routing}@3.0.0 + routing-platform@2.0.0;
routing-functions removed (resolve_route now ships inside routing)
- scoped seed fixtures write logical schemas (routing_public/catalog_public/apps_public)
and seed the compiled hostname_bindings/route_bindings rows directly since the
published schema+grants modules carry no binding-sync triggers
- server-test/playwright tests drop the explicit routingSchema overrides and use
the server default routing_public
- codegen introspection sources query routing_public.api_schemas
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…log/apps@3.1, routing-platform@3) The published surface now carries only the routing read-path resolvers and the catalog-sync propagation triggers; binding-sync stays unpublished so the compiled hostname_bindings/route_bindings rows remain seeded directly. Schema assertion updated for the logical-name plane schemas.
…ting@5.0.0, catalog/apps/routing-platform@4.0.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final step of the logical-name plane migration (constructive-io/constructive-planning#1269): the integration-test fixtures move off the pre-rename npm packages onto the just-published logical set, so tests exercise the exact production shape (
routing_public, the server default from #1466) with no schema overrides.pgpm.json:@constructive-db/{apps,catalog,routing}@3.0.0+routing-platform@2.0.0;routing-functionsdropped —resolve_route()now ships insiderouting.routing_public/catalog_public/apps_publicinstead of theconstructive_*names. The published modules are schema+grants only (no binding-sync triggers), so the scoped fixture now seeds the compiledhostname_bindings/route_bindingsrows directly (hostname_bindings.idmirrors the trigger derivationmd5(domain_id|hostname)::uuid).routingSchema: 'constructive_routing_public'test overrides deleted — the server defaultrouting_publicapplies.graphql/codegenintrospection sources (api-schemas.tset al.) had hardcodedconstructive_routing_publicSQL missed in feat(server): default the scoped routing plane to logical routing_public #1466; now queryrouting_public.api_schemas.Local: server-test suites green (server 34/34, scoped-routing 8/8, express-context 7/7, fn-routes 7/7, upload 39/39 with MinIO).
Link to Devin session: https://app.devin.ai/sessions/ef854ab8e37e4fedbb21bfd777608edd
Requested by: @pyramation