Isolate Graphile plugin and storage data paths - #1655
Draft
yyyyaaa wants to merge 1 commit into
Draft
Conversation
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Part 2 of 6 in the draft tenant-density stack: #1654 → #1655 (this PR) → #1656 → #1657 → #1658 → #1659. It depends on #1654's exact runtime/pool boundary.
The old #1330 fixes were useful, but the later #1333/#1334 strategy required exhaustive SQL rewriting. This PR keeps the plugin fixes while removing that assumption: every built-in operates on the actual physical tenant schemas and exact runtime client. RLS is still row-level defense in depth, not proof that a plugin selected the right object.
What changes
withPgClient(null)/missing-request-context paths. The final Constructive preset wiring is grouped with central build composition in Build exact Graphile schemas from scoped introspection #1657.Validation
Why this remains a draft
Built-in coverage does not sandbox arbitrary Node plugins. Production caller presets are denied by default in #1657, and any explicit opt-in makes that code part of the process/database trusted computing base. Full production-schema grants, multipart byte roundtrips, provider integrations, and hostile cross-tenant runs still have to pass on the final stack.