fix(totp): only request a code for items that carry a seed - #15
Merged
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking a login spammed the main process with
field "seed" not found on item …once a second.ItemDetailguards the polling loop withfields.some(f => f.purpose === 'totp_seed'), butfieldsholds the previous item's fields until the new item'srefresh()resolves — so selecting a login right after a code kept the guard true, and the poller asked for a code with the new item's id.Two changes, either of which alone would stop the crash:
totp.codeis nowPromise<TotpEntry | null>; the renderer clears its interval on a null rather than re-asking every second, andtotpList()filters nulls (akind: 'totp'item whose seed was deleted no longer takes the whole Codes tab down with it).dcrypt vault totp <item>gets the same guard, reporting"<title>" has no one-time-code secretinstead of surfacing the PL/pgSQLRAISE.Link to Devin session: https://app.devin.ai/sessions/04636534e07048089ffb6b78142e12cd
Requested by: @pyramation