ci: run the fetch package's test suite - #120
Merged
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/fetchhas 21 tests that have never run in CI — thetestjob's matrix is a hand-maintained list andfetchwas simply never added to it. That is how #119 (the*.localhostloopback pin, shipped in@constructive-io/fetch@1.2.0and now consumed by constructive-db#2846) merged green without its regression tests ever executing on a runner. Those tests bind real IPv4/IPv6/DNS listeners, so they're exactly the kind that shouldn't be trusted to a local run only.package: - confstash + - fetch - fetch-api-clientWorth noting the same gap exists for nine other packages that declare a
testscript but aren't in the matrix —cel-proto-parser,graphile-pnpm-policy,inquirerer-test,kubernetes-test,rego-deparser,schema-ts-cli,toml-ast,visual-diff,yamlize-cli(three of them have no test files at all). Left alone here to keep this PR to the one package under discussion; deriving the matrix from the workspace instead of hand-maintaining it would kill the whole class of drift.Link to Devin session: https://app.devin.ai/sessions/6f4d8dd9a5834871a379b7e598ccde8c
Requested by: @pyramation