Skip to content

test: Use a config file for pkcs11 module given by OCICRYPT_CONFIG ra… - #225

Merged
stefanberger merged 1 commit into
containerd:mainfrom
stefanberger:test-pkcs11-conf-yml
Jul 30, 2026
Merged

test: Use a config file for pkcs11 module given by OCICRYPT_CONFIG ra…#225
stefanberger merged 1 commit into
containerd:mainfrom
stefanberger:test-pkcs11-conf-yml

Conversation

@stefanberger

Copy link
Copy Markdown
Contributor

…ther than 'internal'

Rather than using the 'internal' shortcut for the OCICRYPT_CONFIG for pkcs11, use an actual config file.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the PKCS11 test setup to use a real OCICRYPT_CONFIG file (written into the test work directory) instead of relying on the internal shortcut, aligning the tests with a more production-like configuration flow.

Changes:

  • Write a PKCS11 YAML configuration file into ${WORKDIR} during setupPKCS11().
  • Point OCICRYPT_CONFIG at that generated config file for PKCS11 encryption/decryption tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread script/tests/test_encryption.sh Outdated
…ther than 'internal'

Rather than using the 'internal' shortcut for the OCICRYPT_CONFIG for pkcs11,
use an actual config file.

Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
@stefanberger
stefanberger force-pushed the test-pkcs11-conf-yml branch from dfe9b93 to e642d22 Compare July 30, 2026 18:16
@stefanberger
stefanberger merged commit c2cca62 into containerd:main Jul 30, 2026
8 checks passed
@stefanberger
stefanberger deleted the test-pkcs11-conf-yml branch July 30, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants