save: add --quiet/-q to suppress progress output#5064
Merged
Conversation
Signed-off-by: s3onghyun <s3onghyun@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4958.
nerdctl savealways writes a progress bar to stderr, which clutters logs when it is used in scripts and CI. This adds a--quiet/-qflag that suppresses the progress output.The implementation mirrors the existing
--quietflag onnerdctl load: the flag is threaded intoImageSaveOptions.Quiet, and when set, the transfer progress handler writes toio.Discardinstead ofos.Stderr. The archive itself is written exactly as before; only the progress output is suppressed.cmd/nerdctl/image/image_save.go: register-q, --quietand pass it into the optionspkg/api/types/image_types.go: addQuiettoImageSaveOptionspkg/cmd/image/save.go: route progress toio.Discardwhen quietdocs/command-reference.md: document the flagcmd/nerdctl/image/image_save_test.go: addTestSaveQuietverifying the archive is still produced correctly with--quietManual check:
nerdctl save --helpnow lists-q, --quiet Suppress the progress output.