Remove gogo vanity command and gogo dependency#239
Merged
Conversation
Signed-off-by: Jordan Liggitt <liggitt@google.com>
Contributor
Author
|
cc @dmcgowan |
estesp
approved these changes
Jun 9, 2026
Contributor
Author
|
any chance of getting a tag containing these changes? That would help us ripple out dropping this dep from kubernetes and cadvisor (and containerd main in time for 2.4) |
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/hold for discussion
This repo has an example command that builds a vanity gogo proto generator. This results in passing along the (unmaintained, deprecated) gogo dependency to every downstream, even ones that don't use it. It doesn't look like the command or plugin has been touched in about ~8 years. (xref https://github.com/gogo/protobuf#deprecated-protocol-buffers-for-go-with-gadgets for deprecated status of that repo, and kubernetes/kubernetes#96564 for examples of downstreams trying to drop it out of dependency trees)
I can't find any use of the gogo command within containerd or kubernetes projects
There is some use I could find ... I'm a little fuzzy about what we'd recommend users do... switch to the
protoc-gen-go-ttrpcgenerator? (the in-repo example seems to only be generated with the protoc-gen-go-ttrpc generator)If users can switch to a standard generator with no impact, can we drop the gogo vanity command and this dependency? If dropping it would be problematic, could we move it to an example subfolder with its own isolating go.mod file to drop it out of the main module dependencies?
/cc @samuelkarp