Skip to content

Remove gogo vanity command and gogo dependency#239

Merged
estesp merged 1 commit into
containerd:mainfrom
liggitt:gogo
Jun 9, 2026
Merged

Remove gogo vanity command and gogo dependency#239
estesp merged 1 commit into
containerd:mainfrom
liggitt:gogo

Conversation

@liggitt

@liggitt liggitt commented May 28, 2026

Copy link
Copy Markdown
Contributor

/hold for discussion

This repo has an example command that builds a vanity gogo proto generator. This results in passing along the (unmaintained, deprecated) gogo dependency to every downstream, even ones that don't use it. It doesn't look like the command or plugin has been touched in about ~8 years. (xref https://github.com/gogo/protobuf#deprecated-protocol-buffers-for-go-with-gadgets for deprecated status of that repo, and kubernetes/kubernetes#96564 for examples of downstreams trying to drop it out of dependency trees)

I can't find any use of the gogo command within containerd or kubernetes projects

There is some use I could find ... I'm a little fuzzy about what we'd recommend users do... switch to the protoc-gen-go-ttrpc generator? (the in-repo example seems to only be generated with the protoc-gen-go-ttrpc generator)

If users can switch to a standard generator with no impact, can we drop the gogo vanity command and this dependency? If dropping it would be problematic, could we move it to an example subfolder with its own isolating go.mod file to drop it out of the main module dependencies?

/cc @samuelkarp

Signed-off-by: Jordan Liggitt <liggitt@google.com>
@liggitt

liggitt commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

cc @dmcgowan

@fuweid fuweid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we stop using gogo since d240c50

@estesp estesp merged commit d99e7d7 into containerd:main Jun 9, 2026
11 checks passed
@liggitt

liggitt commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

any chance of getting a tag containing these changes? That would help us ripple out dropping this dep from kubernetes and cadvisor (and containerd main in time for 2.4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants