[1.21] runtime-flag (debug) test: handle old & new runc - #3407
Merged
openshift-merge-robot merged 1 commit intoJul 28, 2021
Merged
Conversation
Between runc-1.0.0-70.rc92 and 1.0.1-3, debug messages changed entirely. Old runc is a short and sweet list: time="..." level=debug msg="nsexec:601 nsexec started" time="..." level=debug msg="child process in init()" time="..." level=debug msg="logging has already been configured" New runc is pages and pages of gobbledygook which I'm not going to paste here but which, basically, is completely different. Better, because most messages now include "runc", but different. These buildah tests need to pass in environments with old and new runc. As best I can determine, the "child process in init" message is the only string common to both old and new runc. Use it as our gauge. (Note: I considered using a regex pattern containing both "nsexec" and "runc". That's less maintainable. If/when runc changes debug messages again, we may need to go that route, but for now let's keep things clean). Signed-off-by: Ed Santiago <santiago@redhat.com>
vrothberg
changed the title
vrothberg
reviewed
Jul 28, 2021
vrothberg
left a comment
vrothberg
left a comment
Contributor
There was a problem hiding this comment.
LGTM
@rhatdan @nalind @TomSweeneyRedHat PTAL
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Between runc-1.0.0-70.rc92 and 1.0.1-3, debug messages changed
entirely. Old runc is a short and sweet list:
time="..." level=debug msg="nsexec:601 nsexec started"
time="..." level=debug msg="child process in init()"
time="..." level=debug msg="logging has already been configured"
New runc is pages and pages of gobbledygook which I'm not going to
paste here but which, basically, is completely different. Better,
because most messages now include "runc", but different.
These buildah tests need to pass in environments with old and
new runc. As best I can determine, the "child process in init"
message is the only string common to both old and new runc.
Use it as our gauge. (Note: I considered using a regex pattern
containing both "nsexec" and "runc". That's less maintainable.
If/when runc changes debug messages again, we may need to go
that route, but for now let's keep things clean).
Signed-off-by: Ed Santiago santiago@redhat.com
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?