Skip to content

[release-1.23] run: add container gid to additional groups - #4264

Merged
flouthoc merged 1 commit into
podman-container-tools:release-1.23from
nalind:additional-groups-1.23
Sep 19, 2022
Merged

[release-1.23] run: add container gid to additional groups#4264
flouthoc merged 1 commit into
podman-container-tools:release-1.23from
nalind:additional-groups-1.23

Conversation

@nalind

@nalind nalind commented Sep 19, 2022

Copy link
Copy Markdown
Contributor

When container is created with specific uid and gid also add container gid to supplementary/additional group.

Cherry-picked from #4207, related to GHSA-rc4r-wh2q-q6c4.

@rhatdan

rhatdan commented Sep 19, 2022

Copy link
Copy Markdown
Contributor

/lgtm
/hold

When container is created with specific uid and gid also add container
gid to supplementary/additional group.

Signed-off-by: Aditya R <arajan@redhat.com>
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@nalind
nalind force-pushed the additional-groups-1.23 branch from 1768610 to 7acef8f Compare September 19, 2022 18:57
@openshift-ci openshift-ci Bot removed the lgtm label Sep 19, 2022

@flouthoc flouthoc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/lgtm
/hold cancel

@openshift-ci

openshift-ci Bot commented Sep 19, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flouthoc
flouthoc merged commit 0f561f6 into podman-container-tools:release-1.23 Sep 19, 2022
@nalind
nalind deleted the additional-groups-1.23 branch September 19, 2022 19:43
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants