[release-1.26] run: add container gid to additional groups - #4266
Merged
openshift-merge-robot merged 2 commits intoSep 19, 2022
Merged
Conversation
When container is created with specific uid and gid also add container gid to supplementary/additional group. Signed-off-by: Aditya R <arajan@redhat.com>
Contributor
|
/lgtm |
Released and used version of https://github.com/etcd-io/bbolt/tree/v1.3.6 does not defines certain constants for `loong64` ARCH so avoid building for `loong64` in `make cross` and `cross-build` CI test. Remove this commit once `v1.3.7` is out since this is fixed on master branch. [NO NEW TESTS NEEDED] [NO TESTS NEEDED] Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
approved these changes
Sep 19, 2022
flouthoc
left a comment
flouthoc
left a comment
Contributor
There was a problem hiding this comment.
LGTM
/lgtm
/hold cancel
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When container is created with specific uid and gid also add container gid to supplementary/additional group.
Cherry-picked from #4207, related to GHSA-rc4r-wh2q-q6c4.