Add manifest list types #608
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalind
force-pushed
the
manifest-list-types
branch
2 times, most recently
from
274ba46 to
0295f35
Compare
Member
Add the manifest.List interface, and implementations for OCIv1 Index and Docker Schema2List documents. Update image.ChooseManifestInstanceFromManifestList() to use the manifest.List implementations. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
manifest-list-types
branch
from
0295f35 to
39c4923
Compare
Member
Author
|
Rebased. |
Member
|
LGTM |
Member
|
@nalind Any progress or do we need someone else to take this over. |
Member
|
@mtrmac @vrothberg @nalind What should we do with this PR? If @nalind is too busy to work on this should we get someone else to take it over? |
Contributor
|
We should get this moving along 👍 |
Member
Author
|
This turns out to have been lacking as an attempt at extracting just the type parts of #400 to get something smaller. I'm going to revive that one instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
manifest.Listinterface, and implementations for OCIv1 Index and Docker Schema2List documents, and updateimage.ChooseManifestInstanceFromManifestList()to use themanifest.Listimplementations.This is a piece of #400, but hopefully more manageable in scope than it is.