tag: Support tagging manifest list instead of resolving to images - #12057
Merged
openshift-merge-robot merged 1 commit intoOct 21, 2021
Merged
Conversation
flouthoc
added
the
needs-backport
Contributor
Author
|
Needs Backport: to v3.4 RPM and 4.0.0-dev source |
vrothberg
reviewed
Oct 21, 2021
vrothberg
left a comment
vrothberg
left a comment
Contributor
There was a problem hiding this comment.
LGTM
@containers/podman-maintainers PTAL
Contributor
|
@flouthoc what is |
Contributor
Author
|
@vrothberg I dont exactly know i assumed its a tag/release since @cevich mentioned in the issue #12046 |
Following commit makes sure when buildah tag is invoked on a manifest list, it tags the same manifest list instead of resolving to an image and tagging it. Port of: podman-container-tools/buildah#3483 Signed-off-by: Aditya Rajan <arajan@redhat.com>
flouthoc
force-pushed
the
allow-tagging-manifest-list
branch
from
October 21, 2021 12:14
5d868c9 to
f4f9696
Compare
Contributor
Author
|
pushing changes for |
Contributor
|
/lgtm |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Nov 1, 2021
… images Following commit makes sure when buildah tag is invoked on a manifest list, it tags the same manifest list instead of resolving to an image and tagging it. Backporting podman-container-tools#12057 Signed-off-by: Aditya Rajan <arajan@redhat.com>
github-actions
Bot
added
the
locked - please file new issue/PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following commit makes sure when podman tag is invoked on a manifest
list, it tags the same manifest list instead of resolving to an image and
tagging it.
Port of: podman-container-tools/buildah#3483
Closes: #12046
Needs Backport: to v3.4 RPM and 4.0.0-dev source