test/system: quadlet use correct systemd restart policy

[Luap99]

Systemd doesn't support never and logs a warning, systemd uses no as default so we do not have to specify it at all.

Check systemd.service(5) for the systemd docs.

Fixes #18743

Does this PR introduce a user-facing change?

None

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

@edsantiago PTAL

[TomSweeneyRedHat]

if @edsantiago is hip with this, LGTM

[edsantiago]

LGTM but I think it's more than just that one test:

$ ack 'Restart.*nev'
cmd/podman/common/create.go
634:                    [removed, I think this one is OK, it's not systemd]
 
contrib/systemd/system/podman-play-kube@.service
10:Restart=never
 
pkg/util/utils.go
674:            if strings.ToLower(splitRestart[0]) == "never" {
               [I think this one is ok also]

And, in the process of searching for combinations of restart+never (while ignoring the kube restartPolicy), I found:

podman/test/system/250-systemd.bats

Lines 450 to 462 in 5543de2

	# Kill the pod and make sure the service is not running.
	# The restart policy is set to "never" since there is no
	# design yet for propagating exit codes up to the service
	# container.
	run_podman pod kill test_pod
	for i in {0..20}; do
	run systemctl is-active $service_name
	if [[ $output == "failed" ]]; then
	break
	fi
	sleep 0.5
	done
	is "$output" "inactive" "systemd service transitioned to 'inactive' state: $service_name"

which seems to be obsolete. Would you be willing to take those on as part of this PR? If not, np, I can file an issue. I'm just not comfortable submitting a PR because there are edge cases I'm sure I haven't considered.

[Luap99]

contrib/systemd/system/podman-play-kube@.service

This is not checked into git, I do not have such file locally. Looks like it was renamed and then fixed in d7f6d35

The 250-systemd test change I cannot really tell we should wait for @vrothberg to comment on that. It tests the behavior without exit policy and the kube template does not set one so it is fine IMO.

[edsantiago]

Ack, thanks. And sorry for false-alarming on a dead file.

/lgtm

[vrothberg]

Opened #18854 to remove the confusing comment.