Adding Umask= key to Quadlet .container files. #25293
Conversation
|
|
||
| ### `Umask=` | ||
|
|
||
| Set the umask of the process. This is equivalent to the Podman `--umask` and generally has the form `[UMASK]` |
There was a problem hiding this comment.
Remove the "and generally has the form [UMASK]" part I don't see how this adds any value and what means form [UMASK]?
test/e2e/quadlet_test.go
Outdated
| Entry("sysctl.container", "sysctl.container"), | ||
| Entry("timezone.container", "timezone.container"), | ||
| Entry("ulimit.container", "ulimit.container"), | ||
| Entry("umask.container", "umask.container") |
There was a problem hiding this comment.
indentation looks wrong also you are missing a comma here at the end
pkg/systemd/quadlet/quadlet.go
Outdated
| service.PrependUnitLine(UnitGroup, "Wants", networkUnit) | ||
| } | ||
| } | ||
|
|
|
Fixed (I hope) |
|
LGTM |
|
please squash your commits into one |
|
Code/tests LGTM once commits are squashed |
|
Use Then you also need to rebase on main to fix the CI issue with Hope this helps |
|
Okay, thank you, I learned some more today :). I followed you instructions carefully so that should be it. |
|
@geraveoyomama Please see @Luap99's comment: #25293 (comment) about squashing and signing off the commit |
|
I think I will just redo the changes manualllly since its not that much work copying anyway. I simply cannot get it to behave even when following luap's instructions |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: geraveoyomama The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
whoa that was not supposed to happen |
|
opening again soon EDIT: or not?? Continued in #25369 |
stale-locking-app
bot
added
the
locked - please file new issue/PR
5 participants
Does this PR introduce a user-facing change?
Closes #25278