-
Notifications
You must be signed in to change notification settings - Fork 2.9k
adding Umask key to Quadlet. (2nd attempt) #25369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Luap99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, code wise LGTM but please fix your commit message,
remove Committer: Gerben Damave <gerben@hephaestus.s8n.nl> and then make sure you have an empty line before adding Fixes #25278.
You can edit the commit message with git commit --amend and then just force push the commit again.
TomSweeneyRedHat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once signed and other DCO issues are addressed.
|
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
there are some build failures. But from the logs I do not see how I can fix them |
|
@geraveoyomama Please rebase on top of main. I hope this will fix these issues |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: geraveoyomama The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Committer: Gerben Damave gerben@hephaestus.s8n.nl
Does this PR introduce a user-facing change?
attempt no. 2
Closes #25278