Skip to content

Conversation

@geraveoyomama
Copy link

Committer: Gerben Damave gerben@hephaestus.s8n.nl

Does this PR introduce a user-facing change?

Adds the Umask= key for .container is added to the quadlet generator.

attempt no. 2

Closes #25278

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, code wise LGTM but please fix your commit message,
remove Committer: Gerben Damave <gerben@hephaestus.s8n.nl> and then make sure you have an empty line before adding Fixes #25278.
You can edit the commit message with git commit --amend and then just force push the commit again.

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once signed and other DCO issues are addressed.

@packit-as-a-service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

1 similar comment
@packit-as-a-service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@geraveoyomama
Copy link
Author

there are some build failures. But from the logs I do not see how I can fix them

@ygalblum
Copy link
Contributor

@geraveoyomama Please rebase on top of main. I hope this will fix these issues

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: geraveoyomama

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jul 24, 2025
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jul 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Umask=xxxx option to replace PodmanArgs=--umask=xxxx

4 participants