Skip to content

go.mod: fix go version#723

Closed
rhatdan wants to merge 1 commit into
containers:masterfrom
rhatdan:master
Closed

go.mod: fix go version#723
rhatdan wants to merge 1 commit into
containers:masterfrom
rhatdan:master

Conversation

@rhatdan
Copy link
Copy Markdown
Member

@rhatdan rhatdan commented Sep 24, 2020

Commit 1a28477 (inadvertently?) changed go version in go.mod from 1.13
to 1.15.

A "go " line in go.mod sets minimum go version required for the
package (see [1]). I don't think containers/storage suddenly requires go
1.15+.

Set it to 1.14, which is currently the oldest supported release.

[1] https://golang.org/ref/mod#go-mod-file-go

Signed-off-by: Kir Kolyshkin kolyshkin@gmail.com

Commit 1a28477 (inadvertently?) changed go version in go.mod from 1.13
to 1.15.

A "go <version>" line in go.mod sets minimum go version required for the
package (see [1]). I don't think containers/storage suddenly requires go
1.15+.

Set it to 1.14, which is currently the oldest supported release.

[1] https://golang.org/ref/mod#go-mod-file-go

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@rhatdan
Copy link
Copy Markdown
Member Author

rhatdan commented Sep 24, 2020

Complete/Replace #718 PR

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

For hysterical purposes, could you add some info on the mounted change in the commit description please?

@kolyshkin
Copy link
Copy Markdown
Contributor

Sorry I missed the note in #718; please see #724

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

I'm going to close this in favor of @kolyshkin 's #724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants