Fix go.mod; simplify pkg/mount.Mounted#724
Merged
Merged
Conversation
Commit 1a28477 (inadvertently?) changed go version in go.mod from 1.13 to 1.15. A "go <version>" line in go.mod sets minimum go version required for the package (see [1]). I don't think containers/storage suddenly requires go 1.15+. Set it to 1.14, which is currently the oldest supported release. [1] https://golang.org/ref/mod#go-mod-file-go Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Since moby/sys/mountinfo v0.2.0, the path does not have to be normalized, so drop our wrapper. Note this slightly change the call semantics: previously, a non-existing path resulting in an error (wrapped ENOENT), while now it will return "not mounted". The change is intentional -- the call is not to check if the path exists, it is to check whether it is mounted. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Closed
Member
Member
|
While I am okay to revert the |
Member
|
LGTM |
Contributor
Author
AFAIK this is about both tooling features as well as the code (I barely remember seeing some code-related error, alas I don't remember what it was). |
rhatdan
added a commit
that referenced
this pull request
Sep 29, 2020
Fix go.mod; simplify pkg/mount.Mounted Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carry of #720
Closes: #723
1. go.mod: fix go version
Commit 1a28477 (inadvertently?) changed go version in go.mod from 1.13
to 1.15.
A "go " line in go.mod sets minimum go version required for the
package (see [1]). I don't think containers/storage suddenly requires go
1.15+.
Set it to 1.14, which is currently the oldest supported release.
[1] https://golang.org/ref/mod#go-mod-file-go
2. pkg/mount: rm path normalization from Mounted
Since moby/sys/mountinfo v0.2.0, the path does not have to be
normalized, so drop our wrapper.
Note this slightly change the call semantics: previously, a non-existing
path resulting in an error (wrapped ENOENT), while now it will return
"not mounted". The change is intentional -- the call is not to check if
the path exists, it is to check whether it is mounted.