cmd/initContainer: fix /etc/localtime handling for Ubuntu containers.#634
Merged
Conversation
likan999
added a commit
to likan999/ppa-toolbox
that referenced
this pull request
Nov 28, 2020
On Ubuntu host and images, the `/run/host/etc/localtime` points to `/usr/share/zoneinfo/SomeTimeZone`; which breaks current code that assumes it point to `/run/host/usr/share/zoneinfo/SomeTimeZone`. containers#634
|
Build failed.
|
On Arch Linux and Ubuntu hosts, /etc/localtime is an absolute symbolic link to /usr/share/zoneinfo/SomeTimeZone. So, inside the container, /run/host/etc/localtime also has /usr/share/zoneinfo/SomeTimeZone as its target. containers#622
|
Build succeeded.
|
Member
|
I updated the commit message to include #622 Thanks for working on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Ubuntu host and images, the
/run/host/etc/localtimepoints to/usr/share/zoneinfo/SomeTimeZone; which breaks current code that assumes it point to/run/host/usr/share/zoneinfo/SomeTimeZone.