Not enough memory warning screen#96
Conversation
Added a method which checks the ram allocation and then gives a warning if it is offset by 1100 MB from the recommended max ram allocation. The offset for 1100 is set because AA-like categories use about 1000 MB more than other categories. MultiMC's Ram Allocation amounts may pass the 1000 MB barrier, to avoid it we add 100 more to the 1000 MB. There's also a system property to disable it.
Replaced the log message with a screen, removed the upper memory limit.
|
This looks pretty good, I have a couple things I would like changed though:
|
- Change the low memory warning to trigger when starting resetting, not on launch, as it depends on the max queued seeds config. - Mention max queued seeds in the warning, and link to the wiki.
Makes sense, I've moved the warning to starting resetting. Idk if this injection point is ideal though, but seems to work fine?
I've added a mention of max queued seeds and a link to a non-existing wiki page, I have a stub here if you'd like to add it (although you'd have to update image links). |
What should be the threshold if I were to change that? It probably doesn't make sense to recommend allocating 6 gb if they have 8 gb total, but idk that depends on a lot of factors. |
I know maskers has some threshold calculation in pingus recommended_settings, probably best to just copy that, I'll ping him on discord |
contariaa
left a comment
There was a problem hiding this comment.
This will currently also show a warning for people who havent actually set up seedqueue but have a very low amount of allocated ram (iirc multimc defaults to 1GB). While this isnt inherently bad, the warning screen doesnt accurately tell the user whats going on, so it would probably be easiest to just disable the check if config.maxCapacity is 0.
I'm also a bit worried that the link may not be super obvious, not everyone will hover the text since links arent very common in Minecrafts UI, I'd prefer just adding the link to the end.
contariaa
left a comment
There was a problem hiding this comment.
Looks good to me, thank you for the PR :)
Follow-up on #65.
Added a warning screen shown on startup if JVM's max memory (-Xmx) is below a set threshold.