fix/select types#25
Merged
jonasnobile merged 3 commits intomainfrom Apr 22, 2026
Merged
Conversation
When the second slot is `any`, TypeScript fails to infer the entity for narrowly-selected refs (e.g. `entity.family` typed via `createComponent().entity(s, e => e.family(f => f.name()))`). The mapped-type half of the alias intersection poisons inference and the conditional silently falls through to `object`. Letting TS pick the second slot via `infer _S` restores correct inference. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
`HasOneRef<T,S,...>` and `EntityRef<T,S,...>` are aliases that intersect a plain interface with a mapped type, which makes hand-rolled `F extends HasOneRef<infer E, any> ? E : ...` patterns fail to infer when `S` is a narrow subset of `T`. Routing through `*RefInterface` sidesteps that. Expose the helpers and document the pitfall on the alias declarations so consumers don't reinvent the broken pattern. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Documents the broken `<infer T, any>` patterns as regression guards, alongside the safe `<infer T, infer _S>` form and the new ExtractHasOneEntity / ExtractHasManyEntity / ExtractEntityRefEntity helpers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.