fix: use native Windows drag instead of custom timer polling#102
Merged
fix: use native Windows drag instead of custom timer polling#102
Conversation
The custom Win32 timer-based drag (SetTimer + SetWindowPos polling) bypassed Windows' native window move loop, breaking snap gestures, unmaximize-on-drag, and snap layouts on Windows 11. GPUI's WindowControlArea::Drag properly maps to HTCAPTION in WM_NCHITTEST, so native drag works correctly without the workaround. Closes #101 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetCursorPos+SetWindowPosevery 16ms, bypassing Windows' native window move loopWindowControlArea::Dragon all platforms, which maps toHTCAPTIONinWM_NCHITTESTon Windowsraw-window-handledependency (no longer needed)The original workaround (commit 8ee1a8f) was introduced under the assumption that
WindowControlArea::Dragwas a no-op on Windows, but GPUI fully implements the hit test callback chain: element hitbox →on_hit_test_window_control→HTCAPTION→ native drag.Closes #101
Test plan
🤖 Generated with Claude Code