fix: fall back to macOS Keychain when credentials file lacks OAuth token#90
Merged
fix: fall back to macOS Keychain when credentials file lacks OAuth token#90
Conversation
The credentials file (~/.claude/.credentials.json) may exist but not contain the claudeAiOauth key, causing read_access_token() to succeed on file read but fail on token extraction—skipping the Keychain fallback entirely. Now checks for the actual token before considering the file source exhausted. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.claude/.credentials.jsonexists but doesn't contain theclaudeAiOauthkeymcpOAuth) causing the file read to succeed, which skipped the macOS Keychain fallback entirelyChanges
read_access_token()to check for the actual token in the file before considering it a valid sourceclaudeAiOauth.accessToken, now correctly falls through to the macOS Keychain lookupTest plan
~/.claude/.credentials.jsoncontaining onlymcpOAuth, verify the Claude extension picks up the token from Keychain~/.claude/.credentials.jsoncontainingclaudeAiOauth, verify it still reads from the filecargo check -p okena-ext-claudepasses