Skip to content

Fix/modal refresh after login [] - #11273

Merged
zacharyyankiver merged 3 commits into
masterfrom
fix/modal-refresh-after-login
Aug 13, 2026
Merged

Fix/modal refresh after login []#11273
zacharyyankiver merged 3 commits into
masterfrom
fix/modal-refresh-after-login

Conversation

@MikeDReynolds68

Copy link
Copy Markdown
Contributor

Purpose

This update addresses the following issues:

Functional

  • Adds a validation check for imsOrg installation parameter to the validateParameters function to prevent the required imsOrg property from being empty.
  • Extends the onAccessTokenReceived callback in the imsAuthProps to close the modal window if the passed imsToken is undefined so users do not need to manually close and reopen it after signing in using the Adobe sign-in modal.
  • Adds the imsOrg to the imsAuthProps used by the registerContentAdvisorAuthService function to ensure users are granted access to the appropriate IMS Organization.
  • Updates the aemTierType installation parameter to support the following options: 'author', 'delivery', 'both' and sets the default value to 'both'.
  • Updates the aemTierType property in the contentAdvisorProps to use value of the installation parameter of the same name if the value is not empty and does not equal 'both'. If the value is empty or equal to 'both', the property is set to ['delivery','author'].
  • Updates the alwaysUseDelivery property in the contentAdvisorProps to be true when the aemTierType property is not equal to 'author'.
  • Moves the showAuthError to a .then block after the await imsInstance.signOut() function.

Cosmetic

  • Updated the descriptions for the installation parameters in index.jsx and README.md
  • Added information for the prefillSelectedAssets installation property to the Installation Parameters table in README.md.
  • Added information for the hideTreeNav and selectionType installation parameters to a new Installation Parameters table in README.md.
  • Moves inline styles in HTML elements in prepareAEMAssetsHTML function to index.css and cleans up override styles to remove excess scrollbars.

Approach

Updates were made to improve user experience.

Testing steps

Functional

  1. Open the configuration settings for the AEM Assets Selector app, remove the 'IMS Organization' value, and save the configuration. The system should display an alert message with the text 'Please add your IMS Organization'.
  2. Add a value for the 'IMS Organization' parameter and save the configuration. The configuration changes should be saved.
  3. Sign out of asset selector and close the modal by clicking anywhere outside the modal. Click the Select assets from AEM button in the content entry. The system should open the assets selector modal and an Adobe sign-in modal. The assets selector modal window should close, leaving the user with only the Adobe sign-in modal. After signing in, clicking the Select assets from AEM button should open the assets selector modal.

Cosmetic

  1. Open the configuration settings for the AEM Assets Selector app. The installation parameters' definitions should match the updated descriptions.
  2. On a content entry, click the 'Select assets from AEM' button to open the assets selector modal. The modal window should not have scrollbars for the modal body or the embedded asset selector. Assets in the grid view of the assets selector should be scrollable and a scrollbar should appear when assets are being scrolled. A scrollbar should be displayed in list view of the assets selector.

Breaking Changes

None

Dependencies and/or References

None

Deployment

None

@zacharyyankiver zacharyyankiver changed the title Fix/modal refresh after login Fix/modal refresh after login [] Aug 13, 2026
@zacharyyankiver
zacharyyankiver merged commit 6056560 into master Aug 13, 2026
15 of 16 checks passed
@zacharyyankiver
zacharyyankiver deleted the fix/modal-refresh-after-login branch August 13, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants