fix(swift): expose hasConsent(method:) as public [NT-3844] - #396
Merged
Conversation
`OptimizationClient.hasConsent(method:)` was missing the `public` modifier on iOS, making it effectively `internal` and unreachable from customer app code. Android and RN/Core already expose it as public; this restores mobile parity for the GA capabilities matrix. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Felipe Mamud (fmamud)
requested review from
Lotfi Anwar L Arif (Lotfi-Arif),
Tim Beyer (TimBeyer) and
Charles Hudson (phobetron)
as code owners
July 31, 2026 14:19
David Nalchevanidze (nalchevanidze)
approved these changes
Jul 31, 2026
Charles Hudson (phobetron)
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publicmodifier to iOSOptimizationClient.hasConsent(method:), restoring parity with Android and RN/Core where the method is already part of the public surface.hasConsentreturnsfalsebefore initialize; returnstruefortrackView/trackClick/trackwhen consent is accepted; and honorsallowedEventTypesselectively when consent is denied.documentation/internal/sdk-knowledge/native/ios.md) to listhasConsentunder the synchronous public API and under the pre-init fallback behavior.Refs NT-3844.
Test plan
pnpm ios:test(requires Xcode — could not run locally on a Command Line Tools-only machine).pnpm format:checkclean.git diff --checkclean.🤖 Generated with Claude Code