fix(core): downgrade baseline resolution logs to debug [NT-3840] - #407
Merged
Felipe Mamud (fmamud) merged 1 commit intoAug 4, 2026
Merged
Conversation
The baseline path in `OptimizedEntryResolver.resolveWithContext` — no selected optimizations, entry not optimized, and no matching optimization entry for the current selections — is the majority case in any real personalization setup, not an anomaly. Logging it at `warn` promoted normal renders into red-boxed LogBox modals in React Native dev. Downgrade those three log calls to `debug`. Real anomalies (broken variant link, misconfigured entry) still log at `warn`. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
David Nalchevanidze (nalchevanidze)
approved these changes
Aug 4, 2026
David Nalchevanidze (nalchevanidze)
left a comment
David Nalchevanidze (nalchevanidze)
left a comment
Contributor
There was a problem hiding this comment.
Charles Hudson (phobetron)
approved these changes
Aug 4, 2026
Felipe Mamud (fmamud)
deleted the
fix/optimized-entry-baseline-log-level-nt-3840
branch
August 4, 2026 09:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OptimizedEntryResolver.resolveWithContextwas logging the baseline path — no selected optimizations, entry not optimized, and no matching optimization entry — atwarn. That path is the majority case in any real personalization setup, not an anomaly. In React Native dev, LogBox promoteswarninto a red-boxed modal, so it read as a fatal error on every screen mount.debug. Real anomalies (broken variant link, misconfigured entry) still log atwarn.debuglevel and to verifywarnis not called for the same messages.Ticket: NT-3840
Test plan
pnpm test:unit— 343 core-sdk tests pass.pnpm lint— clean.pnpm typecheck(core-sdk) — clean.warn-level log for baseline resolution when opening a personalized destination without matching interests. Variant selection still resolves normally.🤖 Generated with Claude Code