Nt 2570 live updates react web implementation#152
Merged
Lotfi Anwar L Arif (Lotfi-Arif) merged 20 commits intomainfrom Feb 27, 2026
Merged
Nt 2570 live updates react web implementation#152Lotfi Anwar L Arif (Lotfi-Arif) merged 20 commits intomainfrom
Lotfi Anwar L Arif (Lotfi-Arif) merged 20 commits intomainfrom
Conversation
Lotfi Anwar L Arif (Lotfi-Arif)
marked this pull request as ready for review
Lotfi Anwar L Arif (Lotfi-Arif)
requested a review
from Alex Freas (akfreas)
as a code owner
Lotfi Anwar L Arif (Lotfi-Arif)
requested a review
from Charles Hudson (phobetron)
- Expand coverage for identified and unidentified users, and add browser testing on Firefox and Safari.
- Update tests and README to match new live updates examples structure
Charles Hudson (phobetron)
force-pushed
the
NT-2570-live-updates-react-web-implementation
branch
from
cd7166e to
02a0cac
Compare
- Integrate personalized content sections and conversion CTA tracking on - Page Two. Update App to pass consent, entries, and identification state to PageTwoPage. - Update pnpm-lock.yaml for new dependencies.
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
- Skip or adjust preview panel tests based on the PUBLIC_OPTIMIZATION_ENABLE_PREVIEW_PANEL environment variable. - Update unidentified user test to allow for both new and return visitor variants.
Lotfi Anwar L Arif (Lotfi-Arif)
requested a review
from Charles Hudson (phobetron)
Charles Hudson (phobetron)
approved these changes
Feb 27, 2026
Collaborator
Charles Hudson (phobetron)
left a comment
Charles Hudson (phobetron)
left a comment
There was a problem hiding this comment.
Looks good! Once we have a better way to hook into the preview panel's attached/open states, we could probably cut out a lot of integration code by just loading it in the host HTML page directly.
Lotfi Anwar L Arif (Lotfi-Arif)
deleted the
NT-2570-live-updates-react-web-implementation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds full React Web live updates behavior coverage and aligns E2E depth with Web Vanilla/RN references.
What changed
implementations/web-react:liveUpdates=true/false)personalizeEntry(..., selectedPersonalizations)).chromium,firefox,webkit).Why
Validation
pnpm --dir implementations/web-react typecheckpasses.pnpm --dir implementations/web-react test:e2e --listshows 57 tests across 3 browsers.