🔥 feat(states): Updating observable state access; adding profile availability state#166
Merged
Charles Hudson (phobetron) merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
09b7e08 to
e24de0e
Compare
…lability state - Refactor shared state internals into a dedicated `signals/` module (`signals.ts` -> `signals/`). - Introduce a richer observable API with `current`, `subscribe`, and `subscribeOnce`. - Deep-clone observable snapshots and subscriber payloads to prevent consumer mutations from leaking into internal SDK state. - Add derived `canPersonalize` state (`personalizations !== undefined`) and expose it via `CoreStateful.states` and `PersonalizationStates`. - Harden interceptor execution by deep-cloning values before each interceptor step to isolate mutations and protect caller-owned references. - Add test coverage for observable clone/one-shot behavior, interceptor clone isolation, and `canPersonalize` state transitions. - Update Core/Web SDK docs for the expanded `states` API and entry-interaction tracking guidance, including hover behavior and options. - Update the `pre-push` checks to more completely scan pushed commits for changes [[NT-2684](https://contentful.atlassian.net/browse/NT-2684)]
e24de0e to
38789ef
Compare
Lotfi Anwar L Arif (Lotfi-Arif)
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
signals/module (signals.ts->signals/).current,subscribe, andsubscribeOnce.canPersonalizestate (personalizations !== undefined) and expose it viaCoreStateful.statesandPersonalizationStates.canPersonalizestate transitions.statesAPI and entry-interaction tracking guidance, including hover behavior and options.pre-pushchecks to more completely scan pushed commits for changes[NT-2684]