💡 refactor(analysis): Cleaning up some small things found during WASM analysis#177
Merged
Charles Hudson (phobetron) merged 1 commit intomainfrom Mar 16, 2026
Merged
Conversation
… analysis - Switch workspace test globals and scripts from Vitest to Rstest - Add lib/mocks test config and align RsDoctor cleanup paths - Remove non-JSON-Schema Zod features from personalization schemas - Add explicit config normalization and JSON Schema export coverage The feasibility analysis of basing Core on Rust-based WASM has ruled the idea infeasible, mostly due to the amount of functionality covered by JS engines that need to either be added manually in Rust code or factored out of Rust somehow. There's a possibility we could convert a smaller subset of Core functionality to Rust and create a WASM from that, and then generate some JS/TS functionality to Rust at build-time for Native platforms, but the added complexity is prohibitive. [[NT-2756](https://contentful.atlassian.net/browse/NT-2756)]
Charles Hudson (phobetron)
requested a review
from Alex Freas (akfreas)
as a code owner
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Charles Hudson (phobetron)
deleted the
NT-2756_cleanup-from-wasm-analysis
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feasibility analysis of basing Core on Rust-based WASM has ruled the idea infeasible, mostly due to the amount of functionality covered by JS engines that need to either be added manually in Rust code or factored out of Rust somehow. There's a possibility we could convert a smaller subset of Core functionality to Rust and create a WASM from that, and then generate some JS/TS functionality to Rust at build-time for Native platforms, but the added complexity is prohibitive.
[NT-2756]