Merge Personalization and Analytics component into OptimizedEntry#188
Merged
Alex Freas (akfreas) merged 1 commit intomainfrom Mar 24, 2026
Conversation
… OptimizedEntry component that handles both cases where personalization or only analytics is desired
Collaborator
|
Looks pretty good to me! |
Alex Freas (akfreas)
requested a review
from Charles Hudson (phobetron)
as a code owner
Charles Hudson (phobetron)
approved these changes
Mar 24, 2026
Alex Freas (akfreas)
deleted the
NT-2698-merge-personalization-components-into-optimizedentry
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the way developers can implement personalization and analytics with our SDK.
<OptimizedEntry/>component that checks if the entry has personalization. If it does not, no attempt at personalization is made<Personalization/>and<Analytics/>componentOpen question: should we consider a case where an entry has a personalization present but the user doesn't want to personalize it? We could solve this by adding an explicit override to disable personalization entirely, but this may be overkill.