💡 refactor(stateless): Add request scopes for per-request Experience options#199
Merged
Charles Hudson (phobetron) merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
Charles Hudson (phobetron)
requested a review
from Alex Freas (akfreas)
as a code owner
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
…options While documenting the Node SDK, it became clear that request-specific Experience API options were being configured on the stateless SDK instance itself. That forced consumers to create a new SDK instance per incoming request just to set values such as `ip`, `locale`, `plainText`, or `preflight`, which works against the intended singleton-style usage and adds unnecessary overhead. Move stateless event emission behind `forRequest(...)` so those request-bound Experience options can be set per request while reusing one SDK instance. - add `CoreStatelessRequestScope` and split shared, stateful, and stateless API config types into `CoreApiConfig` - keep stateless constructor config limited to shared API settings and pass request-bound Experience options through `forRequest(...)` - update the Node SDK, dev harness, and Node reference implementations to reuse one SDK instance and create a request scope per request - add unit coverage for request-bound options and refresh the core and Node docs with a new Node integration guide [[NT-2817](https://contentful.atlassian.net/browse/NT-2817)]
Charles Hudson (phobetron)
force-pushed
the
NT-2817_node-sdk-guide
branch
from
3e39857 to
245197e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While documenting the Node SDK, it became clear that request-specific Experience API options were being configured on the stateless SDK instance itself. That forced consumers to create a new SDK instance per incoming request just to set values such as
ip,locale,plainText, orpreflight, which works against the intended singleton-style usage and adds unnecessary overhead.Move stateless event emission behind
forRequest(...)so those request-bound Experience options can be set per request while reusing one SDK instance.CoreStatelessRequestScopeand split shared, stateful, and stateless API config types intoCoreApiConfigforRequest(...)[NT-2817]