[NT-1754] Surface merge tag functionality in RN implementation#69
Conversation
| .join('') | ||
| } | ||
|
|
||
| export function MergeTagScreen({ |
There was a problem hiding this comment.
looks like a huge file. we could also break it down. in utils and rendered components i guess. maybe we can also give bit description what its trying to achieve as its not that clear from first look.
There was a problem hiding this comment.
While I like the extensive documentation, the app may not be the best place to keep it. It's difficult for me to see how a customer would actually implement Rich Text with Merge Tags, due to the focus on having everything partitioned out and documented/tracked separately. It would be nice if we simply rendered the Rich Text with Merge Tags as it would be in a real-life implementation technically, not with real-life content, just bare-bones integration and rendering code.
da35d82 to
f01b5c5
Compare
… app.tsx into components for lint
f01b5c5 to
8e75e21
Compare
Charles Hudson (phobetron)
left a comment
There was a problem hiding this comment.
👷🏻 🏗️
NT-1754 Surface merge tag functionality in RN implementation
MergeTagScreen.tsxApp.tsx, breaking into componentsThis provides a basic reference implementation for the merge tags in the main React Native implementation app. I have moved the "dev dashboard" functionality out of this PR, it will be reintroduced later on with another ticket.
Here's how the current implementation app looks now: