fix(deps): raise fast-uri override to ^3.1.7 (2 high) (+Claude) - #231
Conversation
SNYK-JS-FASTURI-19502739 / SNYK-JS-FASTURI-19502854 (both high). The existing override floor of ^3.1.6 resolves to 3.1.6, which Snyk reports as vulnerable (fixedIn: 2.4.6 / 3.1.7 / 4.1.4). Raising the floor to ^3.1.7 keeps the fix on the 3.x line - no major move - and stays a caret so future patches float in. This is the only dependency gap left on development: it already carries the scoped istanbul-lib-processinfo > uuid ^11.1.1 override, serialize-javascript ^7.1.0 (resolving 7.1.1), and adm-zip ^0.6.0 with file-upload.ts already adapted to writeZipPromise's void return. Validation: fast-uri resolves 3.1.6 -> 3.1.7; snyk high cleared; build green; 137 tests + 8 suites passing. Note: adm-zip@0.6.0 is still reported high by Snyk with fixedIn: [] - the major bump on development did not resolve it and no fixed release exists. Out of scope here; flagged for a human. #claude_code# 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
✅ BUILD PASSED - All security checks passed |
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, consistent dependency override bump with the lockfile updated accordingly.
Pull request overview
This PR updates the npm overrides floor for the transitive dependency fast-uri to ensure the resolved version is 3.1.7, addressing the referenced high-severity Snyk advisories while staying on the 3.x line.
Changes:
- Bump
fast-urioverride from^3.1.6to^3.1.7inpackage.json. - Update
package-lock.jsonto reflect resolution offast-uri@3.1.7(including new tarball URL and integrity hash).
File summaries
| File | Description |
|---|---|
| package.json | Raises the fast-uri override floor to ^3.1.7. |
| package-lock.json | Updates the resolved fast-uri entry to 3.1.7 with matching metadata. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
Re-target of #230 onto
development(that PR was opened againstmain; closing it in favour of this one).One line changed.
developmentalready carries almost all of the dependency work — this closes the single remaining gap.fast-uri(transitive)^3.1.6→^3.1.73.1.6still resolves inside the vulnerable range (fixedIn: 2.4.6 / 3.1.7 / 4.1.4). Stays on the 3.x line — no major move — and stays a caret so future patches float in.Verified against a pristine
developmentcheckout: it resolvesfast-uri@3.1.6andsnyk testreports it high. With this change it resolves3.1.7and that finding is gone.Why this replaces #230 rather than being retargeted
#230's branch was cut from
main, and the two bases have diverged —developmentis 13 commits ahead ofmain,mainis 6 ahead ofdevelopment. Simply switching #230's base would have dragged those 6 unrelatedmaincommits intodevelopment:touching
.github/CODEOWNERS,.github/workflows/release.yml,.talismanrcandpackage-lock.json. So this is a fresh branch offdevelopmentcarrying only the dependency change.What #230 proposed that
developmentalready hasWorth recording, because it's most of that PR:
developmentuuidoverride to its parent"istanbul-lib-processinfo": { "uuid": "^11.1.1" }, the exact scoped form #230 arrived at after reviewserialize-javascript≥ 7.1.1^7.1.0resolving7.1.1adm-zip→0.6.0(which #230 declined as a breaking change)src/adapters/file-upload.tsalready adapted: theif (!status)success-flag check is gone, replaced bytry/catcharoundwriteZipPromiseThat last one is the behavioural decision #230 explicitly routed to a human rather than guessing at — it has since been made here, correctly.
adm-zipsnyk testondevelopmentreportsadm-zip@0.6.0as high withfixedIn: [], both before and after this change. So the major bump to0.6.0did not resolve the advisory, and no fixed release currently exists. Out of scope for this PR; flagging it so it isn't assumed handled by the version bump.Self code review
One review round. No High or Medium findings.
package.jsonand 3 inpackage-lock.json; confirmedfast-uriis the only package whose version moved.3.xmust not float.overridestouched..talismanrc— no change needed.developmentallowlistspackage-lock.jsonviaignore_detectors: filecontent, not a checksum pin, so the checksum churn that affected themain-based PR doesn't apply here.Validation
npm install— clean ·npm run build— greennpm test— 137 tests, 8 suites, all passingsnyk test— the twofast-urihighs cleared; only the unfixableadm-ziphigh remainsnpm audit— 0Local note (not a repo issue): installing in the workspace checkout 404s on
@contentstack/cli-utilities@1.18.5because the repo-local.npmrcroutes@contentstack/*to GitHub Packages while that package lives on public npm. A pristine checkout without that.npmrcinstalls fine, which is where the validation above was run.