-
Notifications
You must be signed in to change notification settings - Fork 0
Fix issue regarding skipping env variables, suppressing non-dev error messages, parsing URL-formatted env values, update form-data version and handling empty server command inputs. #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ce89e3f
CL-2062 | +Harshi | Fix skip environment variables option with --vari…
SakshiKoli-CS a6cec1f
Merge pull request #68 from contentstack/cl-2062
SakshiKoli-CS df7a271
fix: suppress error message in non-development environments
Harshi-Shah-CS 1125814
Merge pull request #69 from contentstack/cl-2079
Harshi-Shah-CS a9ce937
Add AGENTS.md file
dhruvparekh12 41e3935
Merge pull request #70 from contentstack/CL-2100
dhruvparekh12 6c924f0
fix: environment variable parsing for URL formatted values
Harshi-Shah-CS b474704
Merge pull request #71 from contentstack/cl-2121
Harshi-Shah-CS 4d88437
fix: allow --variable-type flag to accept multiple values
SakshiKoli-CS 5af1aac
Merge pull request #72 from contentstack/cl-1656
SakshiKoli-CS 93a1222
fix: handle empty server command input properly
Harshi-Shah-CS 61dfabf
Merge pull request #73 from contentstack/cl-2125
SakshiKoli-CS f5d4d26
Merge pull request #74 from contentstack/development
SakshiKoli-CS 22cdfd3
Merge branch 'main' into staging
aravindbuilt 8f40568
Update form-data to 4.0.4 and add dependency overrides
Harshi-Shah-CS 01032c5
Merge pull request #76 from contentstack/cl-2180
Harshi-Shah-CS fee53fb
Merge pull request #77 from contentstack/development
Harshi-Shah-CS 709b67d
chore: update version in package.json file
Harshi-Shah-CS d14da8e
Merge pull request #79 from contentstack/cl-2180
Harshi-Shah-CS fb88241
Merge pull request #80 from contentstack/development
Harshi-Shah-CS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| ## Testing instructions | ||
|
|
||
| - Follow the Arrange, Act, Assert structure when writing unit tests. | ||
| - When writing unit tests, create individual unit tests that cover each logical branching in the code. | ||
| - For the happy path, can we have a single unit test where all the top level if conditions are executed? This might help with reducing the number of total unit tests created and still give same test coverage. | ||
| - For the tests for edge cases do not create separate describe blocks, keep the hierarchy flat. | ||
| - For the tests for edge cases, do not skip assertions, its still worth adding all assertions similar to the happy paths tests. | ||
| - Use only jest for writing test cases and refer existing unit test under the /src folder. | ||
| - Do not create code comments for any changes. | ||
|
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.