-
Notifications
You must be signed in to change notification settings - Fork 0
Fix issue regarding skipping env variables, suppressing non-dev error messages, parsing URL-formatted env values, update form-data version and handling empty server command inputs. #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CL-2062 | +Harshi | Fix skip environment variables option with --vari…
fix: suppress error message in non-development environments
Add AGENTS.md file
fix: environment variable parsing for URL formatted values
fix: allow --variable-type flag to support multiple selections
fix: handle empty server command input properly
Fix issue regarding skipping env variables, suppressing non-dev error messages, parsing URL-formatted env values and handling empty server command inputs.
Update form-data to 4.0.4 and add dependency overrides
fix: Update form-data to 4.0.4 and add dependency overrides
chore: update version in package.json file
Update version in package.json file from 1.9.3 to 1.9.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses multiple bug fixes and dependency updates related to Apollo Client integration, environment variable handling, and server command processing. The changes primarily focus on suppressing Apollo deprecation warnings in non-development environments, improving environment variable parsing to support URL-formatted values, allowing multiple --variable-type flag values, properly handling empty server command inputs, and updating the Apollo Client dependency from ^3.11.8 to ^3.14.0.
Key changes include:
- Global console patching in apollo-client.ts to suppress Apollo-specific error/warning messages in production
- New withDeprecationsDisabled helper method to wrap Apollo Client watchQuery calls and prevent deprecation warnings
- Enhanced parseEnvVariablesString method that splits on the first colon only, allowing values with colons (e.g., URLs, database connection strings)
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/util/apollo-client.ts | Added module-level console patching to filter Apollo messages, exported isNotDevelopment flag, and imported setLogVerbosity |
| src/util/logs-polling-utilities.ts | Added withDeprecationsDisabled wrapper and disposeDeprecationHandler methods to suppress Apollo deprecation warnings during watchQuery operations |
| src/commands/launch/index.ts | Updated --variable-type flag to accept multiple values and updated documentation |
| src/adapters/base-class.ts | Added parseEnvVariablesString method for URL-aware parsing and converted single variableType string to array for consistent handling |
| src/adapters/github.ts | Modified server command handling to skip setting empty values and use conditional spread operator in GraphQL mutation |
| src/adapters/file-upload.ts | Same server command handling improvements as github.ts |
| test/unit/util/apollo-client.test.ts | New comprehensive test suite for console suppression behavior in development vs non-development environments |
| src/adapters/github.test.ts | Added tests for deployment flow, server command prompting, and empty input handling |
| src/adapters/file-upload.test.ts | New comprehensive test suite mirroring github.test.ts coverage for file upload adapter |
| src/adapters/base-class.test.ts | Added tests for string-to-array conversion, multiple variable type handling, and URL parsing in environment variables |
| package.json | Bumped version to 1.9.4, upgraded @apollo/client to ^3.14.0, pinned form-data to 4.0.4, added overrides section for axios and form-data |
| package-lock.json | Updated lockfile with new Apollo Client version and overridden dependencies |
| AGENTS.md | New documentation file with testing guidelines for AI agents |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chore: update version in package.json file
fix: skip environment variables option with --variable-type flag
fix: suppress error message in non-development environments
fix: environment variable parsing for URL formatted values
fix: allow --variable-type flag to accept multiple values
fix: handle empty server command input properly