fix(VE-5061): add observer to observe cslp of selected element - #356
Merged
Conversation
srinad007
requested review from
faraazb,
hiteshshetty-dev and
sairajchouhan
and removed request for
a team
February 14, 2025 10:13
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Added focus element observer to observe the focused element's data-cslp attribute and re-evaluate handleBuilderInteraction every time it changes.
Summary: This PR introduces a MutationObserver to monitor changes to the data-cslp attribute of the focused element. When the data-cslp attribute changes, the handleBuilderInteraction function is re-evaluated to ensure the focussed Toolbar update
Changes:
Added a MutationObserver to the handleBuilderInteraction function.
The observer watches for changes to the data-cslp attribute of the focused element.
When a change is detected, the observer disconnects itself and re-calls handleBuilderInteraction with the reEvaluate parameter set to true.
The observer is stored in the global state and properly disconnected when no longer needed.