Remove validate-time landmask code - #34
Merged
Merged
Conversation
…on-classification landmask globato generates a landmask when classifying photons, so the coastline mask built during "ivert validate" to filter offshore misclassifications is no longer needed.
Collaborator
Author
|
Failed same Codacy checks, all other tests passed. Codacy being removed later. Will push changes now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ivert validate(to filter out offshore misclassified photons) redundant.coastline_mask.py(moved toarchive/src/), thefilter_misclassified_photons()function, the mask-subdivision logic insubdivide_dem(), thefilter_misclassifiedparameter threaded throughvalidate_dem()/validate_dem_parallel()/_write_validation_outputs(), the--no_misclassification_filterCLI flag, and the now-unusedcoastline_mask_sources/icesat2_misclassification_error_threshold_mconfig keys.Test plan
python -m py_compile src/ivert/validate_dem.pyruff format/ruff check(via pre-commit)coastline_maskorfilter_misclassifiedinsrc/ivert validateon a sample DEM to confirm output is unaffected