Remove the non-functional plot_results_slope_centrality module - #99
Merged
Conversation
The module could not be imported at all: its first statement is `import import_parent_dir`, a module that does not exist anywhere in the package or its dependencies, so any attempt to load it raised ModuleNotFoundError. That has been true on main for as long as the import has been there. Nothing referenced it -- no imports, no entry point in pyproject.toml, no mention in the docs -- and it is no longer part of the analysis workflow. A local copy has been kept outside the repository.
Records why it went: non-functional and no longer used, rather than a capability being taken away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
src/ivert/plot_results_slope_centrality.py.It was non-functional
The module could not be imported at all. Its first statement is:
import_parent_dirdoes not exist anywhere in the package or its dependencies, so any attempt to load the module raisedModuleNotFoundError. This is pre-existing — it fails identically onmain, and has for as long as that import has been there. It surfaced during #98, where the module was included in theICN001rewrite only so the rule could be enabled.Nothing referenced it
pyproject.tomlThe only matches for the name in the whole repository were the module's own function definition and its own call site, inside the file itself. It is also no longer part of the analysis workflow.
Verification
The rest of the package imports cleanly,
ivert --helpworks,ivert.plot_results_slope_centralityis correctly gone from the editable install, and the fullpreksuite passes.A local copy has been kept outside the repository, so the code is not lost.
🔍 Docs preview: https://ivert--99.org.readthedocs.build/en/99/