Fix Fetchez shift-grid integration - #160
Open
camante wants to merge 1 commit into
Open
Conversation
7 tasks
Contributor
|
Thanks! We actually submitted the same changes to the fetchez module at the same time here and I've also been re-arranging some of the file structure. See #161 . So we can probably close this one as it makes the same fixes to the variables and typos in modules.py (as well as hooks.py). Though I like this test you made, if you just update the import to be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Fix the Transformez Fetchez extension so shift-grid generation uses the current Transformez implementation and preserves the requested destination datum and output epoch.
This fixes the integration path needed by the updated TNM workflow without changing the underlying shift-grid algorithm.
Depends on continuous-dems/fetchez#385.
What changed
The change is limited to:
src/transformez/fetchez/modules/modules.pytests/test_fetchez_module.pyValidation
Repository tests and pre-commit checks pass.
The integration test reproduces the existing failure on the base revision. With this candidate, the same workflow succeeds repeatedly and produces the expected identity shift grid while preserving:
EPSG:5703;2020.0;The candidate was run twice successfully with equivalent output.
Reproducibility
origin/main@16c193763a866266a977cd3623cfd6c8dcca0a8a977b6f9810e9bb8d9254330927bca8b136259a7eSupporting evidence
The attached evidence bundle contains the exact candidate patch, revision identities, validation reports, resolved command, and supporting artifacts generated by dem-devel for this reviewed candidate.
evidence_bundle.zip
Checklist
closes #1)CHANGELOG.mdupdatedREADME.mdupdated🔍 Docs preview: https://transformez--160.org.readthedocs.build/en/160/